Skip to content

Add Stage 5 release candidate validator#1025

Merged
anth-volk merged 1 commit into
mainfrom
agent/stage-5/pr-5-2-release-candidate-validation
May 21, 2026
Merged

Add Stage 5 release candidate validator#1025
anth-volk merged 1 commit into
mainfrom
agent/stage-5/pr-5-2-release-candidate-validation

Conversation

@anth-volk
Copy link
Copy Markdown
Collaborator

@anth-volk anth-volk commented May 19, 2026

Fixes #1024

Summary

  • Add ReleaseCandidateValidator for the 5a_validate_outputs seam, backed by the shared validation core and canonical ValidationReport/ValidationFinding output.
  • Add injectable dependencies for staged artifact presence, validation report presence/status loading, release-manifest preflight, finalized release comparison, and release completion marker checks.
  • Require base release artifacts alongside the regional/national H5 artifact families, and add a presence_only validation-report policy for explicit manual overrides that still require report files to exist.
  • Document the Stage 5 validator seam and add unit coverage for missing artifacts, missing reports, report status/load failures, presence-only overrides, incomplete local-area prefixes, finalized releases, and finalized-marker failures.

Tests

  • ruff check policyengine_us_data/release_promotion tests/unit/release_promotion
  • ruff format policyengine_us_data/release_promotion/validation.py policyengine_us_data/release_promotion/__init__.py tests/unit/release_promotion/test_validation.py
  • uv run --no-sync pytest -q tests/unit/release_promotion/test_validation.py
  • uv run --no-sync pytest -q tests/unit/test_validation_core.py tests/unit/test_stage_contracts.py tests/unit/release_promotion/test_candidate.py tests/unit/release_promotion/test_validation.py
  • uv run --no-sync --with pyyaml python scripts/run_quality_guards.py
  • make lint

@anth-volk anth-volk force-pushed the agent/stage-5/pr-5-1-schemas-candidate-bundle branch from 9398ea5 to f1875c4 Compare May 20, 2026 16:18
@anth-volk anth-volk changed the base branch from agent/stage-5/pr-5-1-schemas-candidate-bundle to main May 20, 2026 19:48
@anth-volk anth-volk force-pushed the agent/stage-5/pr-5-2-release-candidate-validation branch from b78af0f to b799f89 Compare May 21, 2026 18:46
@anth-volk anth-volk force-pushed the agent/stage-5/pr-5-2-release-candidate-validation branch from b799f89 to 31f98e0 Compare May 21, 2026 19:18
@anth-volk anth-volk marked this pull request as ready for review May 21, 2026 19:52
@anth-volk anth-volk merged commit bd157e7 into main May 21, 2026
13 checks passed
@anth-volk anth-volk deleted the agent/stage-5/pr-5-2-release-candidate-validation branch May 21, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move release candidate validation into a library service

1 participant